fix(marker): overwrite value only if type is not defined #21044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21044@ca03ff8 |
100pah
approved these changes
Jun 19, 2025
Ovilia
added
the
PR: supplementary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
#20166 adds
valueto marker information, which may break the case where user-providednameshould be displayed instead. This PR fixes this case by only addingvaluewhentypeis provided and valid.Fixed issues
Details
Before: What was the problem?
renders
655, while it should beABCinstead. Seetest/boxplot.html.After: How does it behave after the fixing?
ABCis displayed.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information